search

unbounce / iidy

iidy (Is it done yet?) -- CloudFormation with Confidence
MIT License
52 stars 7 forks source link

iidy v1.9.0 incorrectly considers SQS queue poilcies invalid #184

Closed Kazzer closed 4 years ago

Kazzer commented 5 years ago

Errors:

error Root.Resources.IncomingCommandsQueuePolicy.Properties.PolicyDocument.Statement.0.Principal: must be a String, got {"AWS":"*"} or must be a List, got {"AWS":"*"} [IAMPolicyDocumentValidator]  
error Root.Resources.IncomingCommandsQueuePolicy.Properties.PolicyDocument.Statement.1.Principal: must be a String, got {"AWS":"*"} or must be a List, got {"AWS":"*"} [IAMPolicyDocumentValidator]  
error Root.Resources.IncomingCommandsQueuePolicy.Properties.PolicyDocument.Statement.2.Principal: must be a String, got {"AWS":"*"} or must be a List, got {"AWS":"*"} [IAMPolicyDocumentValidator]

Code: https://github.com/unbounce/lp-page-server-2/blob/master/infrastructure/resources/cfn-template.yaml#L110-L155

Expected: No errors for valid syntax

This issue prevents any usage of the template.

tavisrudd commented 4 years ago

This has been fixed upstream on unbounce/laundry and iidy no longer reports an issue.