search

unbounce / iidy

iidy (Is it done yet?) -- CloudFormation with Confidence
MIT License
52 stars 7 forks source link

Potential issue with stdout buffering #238

Closed dannosaur closed 4 years ago

dannosaur commented 4 years ago

This may not be an issue with iidy, but I'm raising this anyway for visibility. I use CommandsBefore to enforce templates to be linted with cfn-lint before a stack is updated.

On large templates, this fails with a "null value" error coming from cfn-lint, suspiciously on a 64k boundary. I've raised an issue on the cfn-lint project here, but I'm not sure which project is to blame.

If you download the large template file that kddejong linked to, then run it through iidy (iidy render limit_size.yaml | cfn-lint), you'll see the problem.

Like I said, this might not be an issue with iidy, but there's definitely something weird going on here. Also, only seen with bash (which, when using CommandsBefore, ensures the issue is always seen).

tavisrudd commented 4 years ago

This is on iidy's side. I think it might be something to do with writes to pipes being async on posix.

tavisrudd commented 4 years ago

Ignore that first commit referenced above. I was pushing it to a WIP branch to then cherry pick.