search

unbroken-dome / gradle-testsets-plugin

A plugin for the Gradle build system that allows specifying test sets (like integration or acceptance tests).
MIT License
230 stars 50 forks source link

Support dir-name for scala testSets #48

Closed huggsboson closed 6 years ago

huggsboson commented 6 years ago

@tkrullmann do I need to sign a CLA or anything?

tkrullmann commented 6 years ago

Thanks for the contribution! I think there should be some check if the scala plugin is active (similar to what is done for Groovy and Kotlin), otherwise the sourceSets.scala expression will fail.

huggsboson commented 6 years ago

Good catch. Patch set updated.

I've obviously not been running the tests. I'll figure out how to get those working.

huggsboson commented 6 years ago

I ran the tests. I confirmed with the current PR that they run cleanly.

I also confirmed that they fail if:

  1. I remove the apply plugin in the scala test.
  2. I remove the scala plugin check from the main file (the MissingPropertyException you expected).