Enhancements and Code Fixes: Constructor Parameters, JSDoc, Time Validation, Color Support, and Style Compliance

[devaoto]

In this pull request, I've added some features and fixed some issues.

Added:

• Added parameters on the constructor
• Added JSDoc for better intelligence purpose
• Create time checking function that will check if the time is on valid format or not
• Added time checking
• Add support for "random" color in colorFetch() method

Fixed:

• Fixed class name with it's rules (https://github.com/felixge/node-style-guide#user-content-use-uppercamelcase-for-class-names)
• Reformated the code

[Elitex07]

@codeblitz97 After checking the code, am not able to find anything, which should be merged into the repository. Can you define any?

[devaoto]

@Elitex07 I've added JSDoc for VSCode intelligence (https://jsdoc.app/) it's just comments but it provides intelligence to the VSCode and maybe for other code editors too, then I saw that the class name actually doesn't follow the rules of naming class, so I've changed "musicCard" to "MusicCard" then for making things easier, I've added an object in the main class which has all of the options. For utility, I've added "random" options in the colorFetch() method so we can use: color: "random" in the class object or the class method. Also created an interface for typescript. Last, for error handling I've created a new method that will check if the provided "endtime" or "starttime" is in the format: "min:seconds (0:00 or whatever)" or not, it will throw an error if the time is not in the valid format

[Elitex07]

@codeblitz97 am asking again. Tell things which should be merged.

[devaoto]

@Elitex07 https://github.com/a3pire/musicard/pull/12#issuecomment-1737694580

[Elitex07]

• Only adding spaces will not be considered.
• Intelligence TS is contradictory to what we already have
• Class constructor declaration is also contradictory to what we already have
• We don't want a release with breaking changes, which do not add anything valuable to the repository

[Elitex07]

After this, if you have anything which should be merged, like the error handling of time formats. You should create another pull request with only those changes.

[devaoto]

So you're saying that I should revert the code to the old version and just add the time format checking and nothing else?

[Elitex07]

Kind of yea.

[devaoto]

Okay then, removing everything except time checking, and those spaces were added by my formatter (prettier) automatically so I had no control over that

[Elitex07]

np

[devaoto]

Updated

[flameface]

@codeblitz97 I appreciate your work, and I want to make things clear.

Before you, one guy already sent that class thing to be direct in musicard({ here }), which I just denied because we can't change it as it's our way of presenting it, and we can't change it directly now.

You are saying somewhat about the rules of classes. It's musicCard or MusicCard doesn't matter; I checked the source, and they want to say it shouldn't be music_Card

Last, the time formatting; it's a canvas card; you can do whatever you want; there are no restrictions; and it's not required for now, i think.

[devaoto]

@flameface Yeah, I understand but for the time formatting, will it still work if I provide something like: "oneminute:fiveseconds" or whatever? I don't think so to prevent that I've added that

[flameface]

I like the time formatting, I will check and let you tomorrow. thank you

[flameface]

@flameface Yeah, I understand but for the time formatting, will it still work if I provide something like: "oneminute:fiveseconds" or whatever? I don't think so prevent that I've added that

It will be okay, but till now, I didn't see anyone do that.

[Elitex07]

fr 💀, my bad. Kindly revert it

[devaoto]

@Elitex07 Added package.json and I'm closing this pull but I'm working on something else

[flameface]

All is good to go.

[flameface]

will you pull the request again of that time formatting

[devaoto]

Sure