search

unc-csxl / csxl.unc.edu

CS Experience Labs' web application.
https://csxl.unc.edu
MIT License
9 stars 7 forks source link

357 avoid duplication of polling data in coworking home #373

Closed JohnSchachte closed 2 months ago

JohnSchachte commented 4 months ago

closes #357

All polling will now take place with the RxObject 'RxCoworkingStatus' to avoid duplicate pulling. I also went outside the scope of this branch to refactor how the Room Reservation Service was being utilized and removed duplicate Reservation State Change Methods (like cancel Reservation etc) from this child class in effort to utilize the Reservation Service parent class.

Note: THe original issue: https://github.com/unc-csxl/csxl.unc.edu/issues/357 mentions 'if there is something missing from the status API endpoint, such as the bound of future reservations is too short (worth checking) then we can fix that.'. I was not sure what this was referring to or how to test if this was an issue. Let me know if this is still worth looking into!

JohnSchachte commented 3 months ago

Upated the upcoming reservations to be rendering asynchronously with a property in Coworking Home Component class instead of a method call per Kris. Pulled Main and merged with this branch so there should be no conflicts at this time.