search

unc-csxl / csxl.unc.edu

CS Experience Labs' web application.
https://csxl.unc.edu
MIT License
9 stars 7 forks source link

374 active reservations Ambassador View #375

Closed aarjavjain2002 closed 4 months ago

aarjavjain2002 commented 4 months ago

!! Active Reservations for AMBASSADOR VIEW (NOT Coworking)!!

This PR updates the filtering criteria on the backend for getting all reservations for the AMBASSADOR VIEW (apologies for the branch name, there was a small misunderstanding). Active reservations used to disappear from the Active section after a certain duration. Now all active reservations show up for their full duration and only disappear until the end time is reached or the student checks out/ is checked out.

Yuvraj has also made the following changes: Fixed the table to show booked out slots when the start time slot has been dynamically purged from the table. This prevents conflicting reservations.

There was a bug where past reservations would have a start time outside the table due to the table being dynamic. This caused the reservation to not show up at all and let people double book the room for the same timeslot.

This PR will address that bug and closes #353

KrisJordan commented 4 months ago

Actually, although the fixes look good and I'm going to deploy for improving UX, we do need to circle back here this week and add tests that cover these cases to be sure we don't accidentally regress down the road.