Merging Fully Implemented Group Reservations

tmattvu commented 5 months ago

As a student, when making a room reservation, I now have to add users to my reservation in order to meet the capacity that each room requires.

tmattvu commented 5 months ago

Fixed CR's relating to my code (group reservations). Aarjav will fix the rest of the CR's relating more towards room reservations and the new code for descriptions and capacity! Will do testing once all CR's are resolved!

ajaygandecha commented 4 months ago

@tmattvu / @aarjavjain2002 / @yuvrajjain2003 what is the progress here? I am working on cleaning up branches and PRs so I wanted to check if this needs re-review.

yuvrajjain2003 commented 4 months ago

@tmattvu / @aarjavjain2002 / @yuvrajjain2003 what is the progress here? I am working on cleaning up branches and PRs so I wanted to check if this needs re-review.

I believe that most of the CR responses were resolved, but there are a few where we were waiting on @KrisJordan's input. Although, I believe that most of the implementation features of this PR were already in place. There were only a few design changes that were being deliberated.

I'll loop in @tmattvu and @aarjavjain2002 to confirm this!

aarjavjain2002 commented 4 months ago

@tmattvu / @aarjavjain2002 / @yuvrajjain2003 what is the progress here? I am working on cleaning up branches and PRs so I wanted to check if this needs re-review.

Hi Ajay. I believe I had cleared up all issues that were pertaining to room reservations and updated Matt on the same. I am not sure if he has any more work left on the branch. @tmattvu all yours from here!

tmattvu commented 4 months ago

@tmattvu / @aarjavjain2002 / @yuvrajjain2003 what is the progress here? I am working on cleaning up branches and PRs so I wanted to check if this needs re-review.

Hey Ajay, sorry for the late response, but I believe all I have to do left is testing. I've been a bit busy since the semester ended but I'll try to tackle it later this week!

ajaygandecha commented 2 months ago

@aarjavjain2002 @yuvrajjain2003 @tmattvu I am going to close this PR, since production has diverged extremely far from the last commit on this PR. I recommend attempting to merge main into this and resolve changes!

In addition, for this PR to be approved, I recommend a bit of a re-design to conform to the new Material 3 standards. Here are a few things I would recommend:

You can greatly simplify the group reservation frontend to just include a single autocompleting input with user chips. The <user-chip-list> widget was created by @jadekeegan to achieve this, and I have used it in many places in the new site. I recommend checking out this use case here in the relocated section admin page:

https://github.com/unc-csxl/csxl.unc.edu/blob/82885ede514faec99c2a93df34c15c3a1dd3336c/frontend/src/app/academics/academics-admin/section/section-editor/section-editor.component.html#L62-L65

This looks like the following on the frontend:

(Profile images will show up, if applicable)

In the future, assuming the empty box below is replaced with the interactive seating chart map, this is the aspirational M3 design of the coworking drop-in screen based on the Figma:
Revert changes to rooms, as this has already been accounted for in the M3 update (I believe).
There will be a better guide for updating old developers to the new conventions with the summer site upgrade coming soon, so feel free to ask any questions if you have them!

unc-csxl / csxl.unc.edu

Merging Fully Implemented Group Reservations #416