search

uncefact / spec-jsonld

Exposing the UN/CEFACT vocabulary as web semantics
https://service.unece.org/trade/uncefact/vocabulary/uncefact/
13 stars 5 forks source link

feat: merge Referenced classes with base ones #109

Closed kshychko closed 2 years ago

kshychko commented 2 years ago

use the object class term qualifier for classes that are repeated ref #63

kshychko commented 2 years ago

Diff summary (files too big to provide a normal git diff):

Vocabulary: main branch Number of classes - 136 Number of properties - 1733 Vocabulary: feature branch Number of classes - 212 Number of properties - 1733

Classes that exist in the main branch but missing in the feature branch (were removed from the output in the feature branch) - 32:

unece:Address
unece:Adjustment
unece:AllowanceCharge
unece:BalanceOut
unece:Communication
unece:Dimension
unece:Event
unece:FinancialAccount
unece:FinancialInstitution
unece:Identity
unece:Instructions
unece:Inventory
unece:Location
unece:Material
unece:MonetarySummation
unece:Parameter
unece:Party
unece:Payment
unece:Period
unece:Person
unece:Price
unece:Registration
unece:Status
unece:Tax
unece:Temperature
unece:TradeAgreement
unece:TradeDelivery
unece:TradeLineItem
unece:TradeSettlement
unece:TradeTransaction
unece:TransportEquipment
unece:WorkItem

Classes that exist in the feature branch but missing in the main branch (were added the output in the feature branch) - 112:

unece:AcknowledgementDocument
unece:AdvancePayment
unece:AppliedAllowanceCharge
unece:AppliedTax
unece:AssociatedTransportEquipment
unece:AttachedTransportEquipment
unece:AuthoritativeSignatoryPerson
unece:AvailablePeriod
unece:BasicWorkItem
unece:BirthAddress
unece:BranchFinancialInstitution
unece:CalculatedPrice
unece:CalibratedMeasurement
unece:CancellationStatus
unece:CommunicationEvent
unece:ContactPerson
unece:ControlSettingParameter
unece:CreditorFinancialAccount
unece:CreditorFinancialInstitution
unece:DebtorFinancialAccount
unece:DebtorFinancialInstitution
unece:DeliveryAdjustment
unece:DeliveryInstructions
unece:DisposalInstructions
unece:DocumentContextParameter
unece:DocumentLineDocument
unece:DocumentStatus
unece:EmailCommunication
unece:EmployerIdentity
unece:ExchangedDocument
unece:FinancialAdjustment
unece:FinancialIdentity
unece:FinancialInstitutionAddress
unece:FinancingFinancialAccount
unece:FinancingRequestDocument
unece:FinancingRequestResultDocument
unece:FinancingStatus
unece:FinancingSummaryDocument
unece:GovernmentRegistration
unece:GroupedWorkItem
unece:HandlingInstructions
unece:HaulageInstructions
unece:HeaderBalanceOut
unece:HeaderTradeAgreement
unece:HeaderTradeDelivery
unece:HeaderTradeSettlement
unece:InstalmentPayment
unece:InstructedTemperature
unece:LegalRegistration
unece:LineTradeAgreement
unece:LineTradeDelivery
unece:LineTradeSettlement
unece:LineTradeTransaction
unece:LocationParty
unece:LogisticsLocation
unece:LogisticsPackage
unece:LogisticsStatus
unece:LogisticsTransportEquipment
unece:LogisticsTransportMeans
unece:OperationalParameter
unece:PaymentBalanceOut
unece:PaymentTradeSettlement
unece:PersonIdentity
unece:ProprietaryIdentity
unece:QuarantineInstructions
unece:RadioactiveMaterial
unece:RecordedStatus
unece:ReferencePrice
unece:RegisteredTax
unece:RequestingParty
unece:ReturnableAssetInstructions
unece:SpatialDimension
unece:SpecifiedGeographicalCoordinate
unece:SpecifiedPeriod
unece:SpecifiedTemperature
unece:StoresItemInventory
unece:SubordinateLineTradeAgreement
unece:SubordinateLineTradeDelivery
unece:SubordinateLineTradeSettlement
unece:SubordinateLocation
unece:SubordinateSubordinateLocation
unece:SubordinateTradeLineItem
unece:SupplyChainConsignment
unece:SupplyChainConsignmentItem
unece:SupplyChainEvent
unece:SupplyChainInventory
unece:SupplyChainTradeLineItem
unece:SupplyChainTradeTransaction
unece:TaxRegistration
unece:TelecommunicationCommunication
unece:TemperatureSettingInstructions
unece:TradeAddress
unece:TradeAllowanceCharge
unece:TradeLocation
unece:TradeParty
unece:TradePrice
unece:TradeProduct
unece:TradeSettlementHeaderMonetarySummation
unece:TradeSettlementLineMonetarySummation
unece:TradeSettlementPayment
unece:TradeSettlementPaymentMonetarySummation
unece:TradeTax
unece:TransportEvent
unece:TransportInstructions
unece:TransportPerson
unece:TransportService
unece:TransportServiceLocation
unece:TransportSettingTemperature
unece:TransportWasteMaterial
unece:UniversalCommunication
unece:ValidationStatus
unece:WorkItemDimension
Fak3 commented 2 years ago

Looks good. But please see my suggestion to link classes: https://github.com/uncefact/spec-jsonld/issues/63#issuecomment-1192238784 So maybe keep the merging logic for linking classes instead?