Open VladimirAlexiev opened 2 years ago
It's very hard to disagree on this! :)
@kshychko , we did some work on this - can you double check if this was fixed already, pls?
@Fak3 , how are you doing? We'd love to have you back and attend the calls!!! ❤️
Currently, all Id
properties are rendered as token
(good!) and all other data properties as string
(not good):
grep rangeIncludes uncefact.ttl |sort|uniq -c|sort -rn|less
791 schema:rangeIncludes xsd:string ;
159 schema:rangeIncludes xsd:token ;
In particular:
Indicator
properties should be xsd:boolean
but are currently string, eg
uncefact:wasteReportingExemptionIndicator
schema:rangeIncludes xsd:string ;
Numeric
properties should be xsd:integer
, eg
uncefact:lineCountNumeric
rdfs:comment "The count of the number of lines in this exchanged document." ;
schema:rangeIncludes xsd:string ;
Currently UNCEFACT uses only two literal datatypes:
xsd:string
(791 props) andxsd:token
(159 props).UNCEFACT prop names are made according to ISO/IEC 11179 Metadata Registry (MDR), part 5:2015 Naming and identification principles. The last word of prop names (let's call it "kind") suggests many other datatypes.
Surely trade involves some numbers and some dates?!?
I checked that all props with kind
Id
are xsd:token (good). This query countsxsd:string
props by "kind":xsd:token
xsd:date
xsd:boolean
xsd:integer
xsd:dateTime
Examples:
uncefact:usedToDateQuotaQuantity, uncefact:usedSignalSourceQuantity, taxBasisTotalAmount, taxBasisAllowanceRate
date
ordateTime
candidates:uncefact:occurrenceDateTime
xsd:boolean
candidates:uncefact:nilCarriageValueIndicator, uncefact:nilCustomsValueIndicator, uncefact:nilInsuranceValueIndicator