Prop Name Doublons - Githubissues

uncefact / spec-jsonld

Exposing the UN/CEFACT vocabulary as web semantics

13 stars 5 forks source link

Closed VladimirAlexiev closed 2 years ago

VladimirAlexiev commented 2 years ago

In addition to "IdentificationId" stuttering (#48), there are more insidious dublons in prop names that need fixing

duplicated word: formattedFormattedCancellationAnnouncedLaunchDateTime : but see #52 for a whole family
duplicated word: referenceReferenceTypeCode
duplicated phrase: documentLineDocumentLineStatusCode

VladimirAlexiev commented 2 years ago

locationFunctionFunctionTypeCode -> locationFunctionType

nissimsan commented 2 years ago

Discussing on the call how could make an NDR rule to sort these sorts of situations out.

Best option is likely to simply remove duplicate words right next to each other.

@kshychko please run with this.

kshychko commented 2 years ago

The following NDR rules were implemented to produce the suggested changes in this ticket:

When Object Class Term Qualifier with Object Class Term or/and Data Type Qualifier are used to generate a property name they, are checked if the next word/phrase starts with the same character sequence.
Additional final check splits every property name into words and removes the duplicate word next to each other.