uncefact / spec-jsonld

Exposing the UN/CEFACT vocabulary as web semantics
https://service.unece.org/trade/uncefact/vocabulary/uncefact/
13 stars 5 forks source link

feat: get rid of `Identification` #78

Closed nissimsan closed 2 years ago

nissimsan commented 2 years ago

@kshychko, expecting you to keep me on the straight and narrow here!

An example of a consequence of this "@id": "unece:bICId", which now gets clubbed together as this:

      "schema:domainIncludes": [
        {
          "@id": "unece:FinancialInstitution"
        },
        {
          "@id": "unece:Identity"
        }
      ],

A sort of double-inheritance. Unless this is breaking some rule I am not aware of, this seems to make sense.

kshychko commented 2 years ago

Closing this PR, as we are not changing the entity data when we read a file, but when we produce a key for a class/property. This And the logic is a bit more complex, the change from this branch produces a property with an empty name for Transport_Cargo.Identification.Text for example, so we need to check the representation term value as well. Closing in favor of #81