search

uncefact / spec-jsonld

Exposing the UN/CEFACT vocabulary as web semantics
https://service.unece.org/trade/uncefact/vocabulary/uncefact/
13 stars 5 forks source link

feat: getting rid of "formatted" datetime #80

Closed nissimsan closed 2 years ago

nissimsan commented 2 years ago

@kshychko, again: keep me brutally honest! It's hard to feel certain that I grasp the full consequences of my actions.

But from what I can tell this is a huge improvement. Example: instead of "@id": "unece:formattedExpiryDateTime" it now produces "@id": "unece:certifiedAccreditationExpiryDateTime". That's incredibly more descriptive and useful.

kshychko commented 2 years ago

@nissimsan, I assume the aim is to reduce the number of properties by grouping BBIEs. Removing the word "formatted" from the names should not increase the number of properties, but reduce it. And #52 is referring to the same. So rather than having a separate formattedExpiryDateTime property, we should group BBIEs from it with the ones from expiryDateTime.

nissimsan commented 2 years ago

Closing, the attr should be called expiryDateTime (reused with other expiryDateTime)