uncefact / spec-untp

UN Transparency Protocol
https://uncefact.github.io/spec-untp/
GNU General Public License v3.0
16 stars 17 forks source link

problems in the modeling of Dimension, specific measure props, Measure #123

Closed VladimirAlexiev closed 3 months ago

VladimirAlexiev commented 4 months ago
onthebreeze commented 3 months ago

It's true that, under the schema, an issuer could say "length":{"value":10,"unit":"KGM"} which would technically valid (because KGM is a valid Rec20 code) but semantically nonsense because you obviously don't measure length in kilograms. But whilst I agree, I also dont think it's UNTP's job to define an entire ontology that defines which units can be used for what kind of measure. This argument applies everywhere. For example an issuer might define an address with country code "NZ" and state "NSW" which would also be technically valid but semantically wrong because New South Wales in in Australia not New Zealand. Where do we stop?

I think we have to assume that issuers will put sensible data within reason.

VladimirAlexiev commented 3 months ago

I'm not asking you to make a UoM ontology but to use one properly.

New South Wales in in Australia not New Zealand

Well then, don't use text fields like countryCode, stateCode. Use a class Place and a world gazetteer like Geonames.