uncefact / spec-untp

UN Transparency Protocol
https://uncefact.github.io/spec-untp/
GNU General Public License v3.0
16 stars 17 forks source link

Require batch if serialized? #143

Closed philarcher closed 2 months ago

philarcher commented 3 months ago

I note that https://uncefact.github.io/spec-untp/docs/specification/DigitalProductPassport#product requires that if a serial number of provided, a batch number MUST also be provided. What's the justification for this? I have a feeling this might not be possible in all cases and suggest that it be at most SHOULD, if not MAY.

onthebreeze commented 3 months ago

OK fair enough - agreed.

onthebreeze commented 2 months ago

The text is poorly written. It says

"DPPs may be issued at product class level (i.e. all shoes of the same model) or at the individual item level (ie this specific serialised pair of shoes). serialNumber and/or batchNumber MUST be provided if the DPP is issued at item level."

What it is trying to say is that IF your DPP is about a specific product instance (not a class) then a batch OR serial number must be present. It is perhaps stating the obvious in a confusing way. What if we split that bullet point into three like this:

or something like that?

philarcher commented 2 months ago

Thanks! Closing.