Run prettier on the webhook deploy - or remove it entirely

nissimsan commented 2 months ago

When I raise fixes on JSON files, github runs prettier on my file, making it impossible to see the delicate changes I actually have made. Example: https://github.com/uncefact/spec-untp/pull/168

I could .prettierignore my way around this, but that isn't fixing the root problem.

Options:

Ensure that the webhook deploy of JSONs are subjected to prettier so ALL files are formatted according to the convention
Reconfigure prettier (and make it catch erronous , in JSON files now we're at it)
Remove prettier altogether
Patch-hack file by file (bad)
Accept as is where any manual corrections result in huge, impossible to read PRs (bad)

nissimsan commented 3 weeks ago

Even worse example: here prettier breaks the formatting. Very disruptive.

onthebreeze commented 1 week ago

Strange but I cant repeat this issue with my setup. macBook pro, Github Desktop client, Sublime Text editor. When I make a commit, there is no prettier reformatting happening on GitHub side.

Has anyone else seen this problem?

uncefact / spec-untp

Run prettier on the webhook deploy - or remove it entirely #169