uncefact / spec-untp

UN Transparency Protocol
https://uncefact.github.io/spec-untp/
GNU General Public License v3.0
18 stars 20 forks source link

DPP example update #93

Closed nissimsan closed 6 months ago

nissimsan commented 6 months ago

This PR updates the DPP example substantially:

  1. adds example values instead of types (like "string")
  2. aligns the credential to the VC data model
  3. adds a bunch of LD (assumes "id": "@id" and "type": "@type")
  4. exemplifies a referenced context
  5. links to conformity credentials instead of having them embedded

Pls consider this incremental improvement, I'm not suggesting this to be a final model at all; we have much more to discuss and improve on this still.

onthebreeze commented 6 months ago

The team thinks we should avoid use of real products. Do we have permission from byacre?

nissimsan commented 6 months ago

Haha, fair enough. It's my wife's company, quite a good case (material reuse) and all good permissions-wise. But I'm good changing to fake data - any suggestions?

onthebreeze commented 6 months ago

Ah ok that's good to know.

What I suggest is anything that represents the upstream focus on UNTP - probably still textile & leather related. So a batch of organic cotton and carbon neutral fabric ?

nissimsan commented 6 months ago

Updated now with a synthetic example. Also added @Fak3's good points.

VS Code added the .md formatting. I wrestled with that last week too, it makes the PR ugly but doesn't make any actual difference.

onthebreeze commented 6 months ago

Team agreed to change

But can do that later - merging on the basis that this is much better than what was there before !