unchained-capital / caravan

Bitcoin multisig coordination software
https://unchained-capital.github.io/caravan/
MIT License
203 stars 177 forks source link

Bug: Images are missing for ledger wallet instructions when signing a transaction #112

Open waldenraines opened 4 years ago

waldenraines commented 4 years ago

I'm submitting a…

Expected Behavior

Ledger wallet instructions should be displayed.

Current Behavior

See screenshot. The images for the ledger steps are missing when you attempt to sign a transaction:

82fd277c-777a-4fd4-ad66-32c40431bdfb

Possible Solution

This could actually be a problem in unchained-wallets.

Steps to Reproduce (for bugs)

  1. Create a wallet that includes a ledger as one of the xpubs
  2. Create a spend transaction
  3. Attempt to sign with the ledger
  4. Note that images are missing

Environment

caravan@0.2.0 /home/walden/code/caravan
├── unchained-bitcoin@0.0.13 
└─┬ unchained-wallets@0.0.12 
  └── unchained-bitcoin@0.0.12 

npm: 6.14.4 
node: v12.16.2
Linux 5.6.13-arch1-1 #1 SMP PREEMPT Thu, 14 May 2020 06:52:53 +0000 x86_64 GNU/Linux
bucko13 commented 4 years ago

I think this might be a bug with unchained-bitcoin not having these images yet rather than caravan but I'd have to double check.