unchained-capital / caravan

Bitcoin multisig coordination software
https://unchained-capital.github.io/caravan/
MIT License
203 stars 177 forks source link

fix(sign): pass wallet uuid for signing #324

Closed bucko13 closed 1 year ago

bucko13 commented 1 year ago

Description

Turns out that the wallet uuid which is used now for ledger wallet registrations wasn't getting passed for signing and so the registration was failing validation.

I think this still needs to be fixed in the test suite though unfortunately and possibly at the fixture level (from unchained-bitcoin). But this gets signing working at least.

Does this PR introduce a breaking change?

Does this PR fix an open issue?