unchained-capital / caravan

Bitcoin multisig coordination software
https://unchained-capital.github.io/caravan/
MIT License
203 stars 177 forks source link

Caravan does not recognize Ledger policyHmacs from imported Unchained wallet config files #335

Closed typercampbell closed 7 months ago

typercampbell commented 1 year ago

I'm submitting a

Expected Behavior

When I load up my wallet configuration file, I expect any ledgerPolicyHmacs in my wallet config file to be brought over and fully imported into Caravan as well.,

Current Behavior

Currently, in order to successfully sign with my Ledger in Caravan, I must re-register the device as the ledgerPolicyHmac for my multisig wallet does not carry over. If I don't re-register, I receive Ledger device: UNKNOWN_ERROR (0xb008)

Possible Solution

I am unsure about the solution, but I feel it's worth calling out.

Steps to Reproduce (for bugs)

  1. Register a Ledger with an Unchained vault
  2. Download the config file, and examine it to ensure the policyHac is in the file
  3. Import the file into Caravan and proceed without registering Ledger again
  4. Attempt to sign and receive Ledger device: UNKNOWN_ERROR (0xb008)

Environment

jevidon commented 7 months ago

Ordering and naming were previously an issue but should be resolved now.