search

unchained-capital / caravan

Bitcoin multisig coordination software
https://unchained-capital.github.io/caravan/
MIT License
203 stars 177 forks source link

WIP: Descriptors #340

Closed bucko13 closed 8 months ago

bucko13 commented 1 year ago

Description

This adds support for loading a wallet config from a descriptor as well as the ability to download the descriptors for a loaded wallet config.

import descriptor

This depends on a new beta package that hasn't been released yet: https://github.com/bucko13/caravan-descriptors This package uses bdk under the hood with special bindings that compiles to wasm.

To confirm that the config and descriptors give us the same wallet, we can compare the address list from each config type.

Here's an address list from the config: Screenshot 2023-09-24 at 1 42 39 PM

Here's the address list from the descriptor: Screenshot 2023-09-24 at 1 42 20 PM

Does this PR introduce a breaking change?

Does this PR fix an open issue?

vindard commented 11 months ago

Bump, this would be really useful

bucko13 commented 8 months ago

Bump, this would be really useful

@vindard Good news! The package providing the functionality is now live on npm here.

We've also migrated all of the caravan and related open source code to a monorepo where ongoing development and maintenance will be happening. This includes the functionality originally introduced in this PR! Checkout the new repo at https://github.com/caravan-bitcoin/caravan and the deployment with descriptor support here.