Closed hwinsby closed 8 months ago
Hi @hwinsby!
I'm so sorry I let this hang for so long. I've been working to get all the open source code migrated over to a new monorepo. I believe this will make the development experience much smoother, especially if you want to start digging into any of the bitcoin libraries as well. Good news is that I suspect that most of your changes here should be transferrable to the new code base though, so hopefully that's not too much trouble. I'll hold off on reviewing until it's in the new repo so we keep any conversation logs.
To get started just clone https://github.com/caravan-bitcoin/caravan, install dependencies and run npx turbo run dev
(or install turbo
globally. You'll see the coordinator app in apps/coordinator
and the rest of the code in there should be pretty familiar. Please let me know if you run into any bumps in the developer experience (or submit a PR with readme updates). I definitely am hoping it's as smooth a transition as possible and ideally easier to work with!
Hey @bucko13, I'm so sorry for the late response here! I'm hoping to get working on this next week.
Description:
TestSuiteRun
andTestSuiteRunSummary
component files:connect
fromreact-redux
with hooksuseSelector
anduseDispatch
Redux files associated with
TestSuiteRun.tsx
andTestSuiteRunSummary.tsx
converted to TypeScript:errorNotificationActions
,keystoreActions
,testRunActions
,testSuiteRunActions
keystoreReducer
&testSuiteRunReducer
keystore
&testSuiteRun
Note.tsx
component file:connect
fromreact-redux
with hooksuseSelector
anduseDispatch
No functional changes were made, only refactors. Screenshots below demonstrate no visual changes before vs. after.
Before:
After:
Does this PR introduce a breaking change?
Does this PR fix an open issue?