search

unchained-capital / hermit

Command-line, (SLIP39) sharded wallet designed for air-gapped deployments
https://unchained.com
Apache License 2.0
70 stars 29 forks source link

Ditch pybitcointools #27

Closed destrys closed 4 years ago

destrys commented 4 years ago

Replacing pybitcointools with pycoin. Replicated the pybitcointools functions we were using, no change in existing code or tests.

codecov-io commented 4 years ago

Codecov Report

Merging #27 into master will increase coverage by 0.96%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #27      +/-   ##
=========================================
+ Coverage   57.73%   58.7%   +0.96%     
=========================================
  Files          25      26       +1     
  Lines        1235    1264      +29     
  Branches      168     171       +3     
=========================================
+ Hits          713     742      +29     
  Misses        504     504              
  Partials       18      18
Impacted Files Coverage Δ
hermit/signer/base.py 100% <ø> (ø) :arrow_up:
hermit/bip32.py 100% <100%> (ø)
hermit/wallet.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ac8d30...f3e9e58. Read the comment docs.

destrys commented 4 years ago

I'm not convinced pycoin is the right choice, closing for now.