Load BGraph Node/Edge Files from S3

uncharted-aske / HMI

Apache License 2.0

1 stars 0 forks source link

Load BGraph Node/Edge Files from S3 #141

Closed adamocarolli closed 3 years ago

adamocarolli commented 3 years ago

This PR contains a package change. Please run yarn install

To test that the change works:

Open the bio view and check your network tab. Ensure that the bgraph files are being transferred from S3 successfully.

RosaRomeroGomez commented 3 years ago

I'm seeing the following errors when I run it:

darionco commented 3 years ago

I'm seeing the following errors when I run it:

those are not errors, they are warnings and they come from libraries as seen in the screenshot you posted (look for node_modules), we could stop using those libraries if we really want to silence the warnings.

RosaRomeroGomez commented 3 years ago

I'm seeing the following errors when I run it:

those are not errors, they are warnings and they come from libraries as seen in the screenshot you posted (look for node_modules), we could stop using those libraries if we really want to silence the warnings.

Yes, that's right, they are not errors. I was reading about the side effects thingy on bundling and now I understand the warnings better (at least the two last ones). The other ones then, it is up to you. They seem to be related to some arguments not being the right type but not sure if that can be changed.

darionco commented 3 years ago

Yes, that's right, they are not errors. I was reading about the side effects thingy on bundling and now I understand the warnings better (at least the two last ones). The other ones then, it is up to you. They seem to be related to some arguments not being the right type but not sure if that can be changed.

All of them can be fixed if you want to fork the libraries, fix the warnings and either make PR so the owners of the original libraries adopt your changes or start maintaining your own versions of the libraries. This warnings come from the fact that esbuild is super pedantic about correctness and includes node_modules libraries in its warnings (which every other bundler skips). These are not new issues, they were always there but you just were unaware of them and they are not in our code either.

adamocarolli commented 3 years ago

Closing this PR. I've taken the comments and split it into multiple more focused changes.