uncharted-aske / HMI

Apache License 2.0
1 stars 0 forks source link

[REFACTOR] Grafer component #172

Closed adamocarolli closed 3 years ago

adamocarolli commented 3 years ago

Description: Currently we have all our Grafer logic in a generalized component. However, this component is just splitting up logic with if/else blocks. Additionally, the core logic is minimal as we are just configuring Grapher for that view and loading the data needed for that view.

Additionally, the component is currently placed within the Bio view directory but was also being used in the Knowledge view directory. This is unexpected as components in a view directory should only contain logic pertaining to that view.

This PR decouples the logic into separate Grafer components per view to remove complexity and allow for easier customization of the Grafer config/data.

Testing: Ensure Grafer works in both the knowledge's document cluster space and Bio view

RosaRomeroGomez commented 3 years ago

Thanks!