uncharted-aske / HMI

Apache License 2.0
1 stars 0 forks source link

[FEATURE] Integrate query results with grafer #178

Closed adamocarolli closed 3 years ago

adamocarolli commented 3 years ago

What? Highlight query results on Grafer layers.

Why? Users can now see their queries highlighted in the larger graph for context.

How? Screen Shot 2021-04-07 at 5 15 17 PM

Testing? Run queries and see if the highlights are as expected.

Anything Else?

Screen Shot 2021-04-09 at 1 43 25 PM Screen Shot 2021-04-09 at 1 39 53 PM

RosaRomeroGomez commented 3 years ago

Two comments/thoughts:

image

adamocarolli commented 3 years ago

Two comments/thoughts:

  • I think we want to have Grafer base layer highlighted or visible by default. The idea is the user opens this view to get an overview of the whole COVID-19 knowledge graph. If we have it faded it out by default, it doesn't provide much context to the user. In summary, I think in the default state (when there are no query results), everything should be visible. Then, when we start applying filters and facets, we start applying the idea of background/foreground layers.
  • I've also noticed (and this is probably out of the scope of this PR), that we currently can run queries while Grafer is loading. This currently throws some errors in the console. We might want to disable the search until Grafer is loaded?

image

@RosaRomeroGomez

  1. Good idea! Done in this PR: https://github.com/uncharted-aske/HMI/pull/183
  2. Fixed in this commit: https://github.com/uncharted-aske/HMI/pull/178/commits/d2bb22d64d317394a41ec5850d13b344dd884e63