Add loader component to the Similar document component.

uncharted-aske / HMI

Apache License 2.0

1 stars 0 forks source link

Add loader component to the Similar document component. #179

Closed YohannParis closed 3 years ago

YohannParis commented 3 years ago

What fix #113 Add a loader for the similar document component on the knowledge view document modal.
Why The documents can take time to load (async), this avoids the surprise of documents showing up. Also now we indicate if there are no related documents.
Testing Check on different documents if the loader is showing up or at least the sentence saying that there is no documents or a list of three documents in a row.
Screenshots

mj3cheun commented 3 years ago

Note that the similarDocs fetch function automatically truncates the number of similarDocs to 4. This limit can be safely removed now that the related docs has a scroll.

YohannParis commented 3 years ago

Made the changes so the images are not so big, and that the document are not touching the scrollbar. I checked to make sure to accommodate 4 lines title as well.

mj3cheun commented 3 years ago

Looks good looks good. One last thing, currently if it scrolls then the shadow of the last row is cut off as shown. This can be fixed by removing gap: var(--list-gap); from .list-documents and adding padding (e.g. padding-bottom: var(--list-gap);) to each li instead

Screen Shot 2021-04-16 at 2 05 04 PM

YohannParis commented 3 years ago

I fix the issue about the shadow:

test2

But know I have an issue with multiple lines of text:

I think it might be worth reviewing the design of those related documents. I don't understand why the artifacts have shadows, and why they are necessary. Maybe a simple list of title + author, etc.

mj3cheun commented 3 years ago

Yup good point, definitely something to look at. The shadows I can explain a bit, when theres mostly or even all white images the shadows make it more clear that there is an actual image there. @RosaRomeroGomez what are your thoughts? I think any further changes can be handled in a separate PR tho and I think this is good to go. Thanks a ton!