search

uncharted-aske / HMI

Apache License 2.0
1 stars 0 forks source link

Fix Modal document in bio #202

Closed YohannParis closed 3 years ago

YohannParis commented 3 years ago

Why fix #201

How I added conditions to each visible element of the modal to make sure we do not run in the same kind of issues as explained in #201.

Testing Open any models link evidences to see if the modal page opens without error.

RosaRomeroGomez commented 3 years ago

@mj3cheun could you also take a look at this to see if you can reproduce as well? It seems the modal now opens without errors but the bottom part where we display similar docs seems to hang and just shows the spinner forever.

image

YohannParis commented 3 years ago

@mj3cheun could you also take a look at this to see if you can reproduce as well? It seems the modal now opens without errors but the bottom part where we display similar docs seems to hang and just shows the spinner forever.

I fixed this issue by testing if the doi is undefined or not.