uncharted-aske / HMI

Apache License 2.0
1 stars 0 forks source link

New Homepage, separating Epi and Bio views #209

Closed YohannParis closed 3 years ago

YohannParis commented 3 years ago

Why

How

Screenshot and Video Screen Shot 2021-05-21 at 14 47 42

https://user-images.githubusercontent.com/636801/119735542-7d102700-be4a-11eb-8c8d-ba027b65020a.mov

Testing

YohannParis commented 3 years ago

It seems we should clean up the selectedModel store variable between views (Graphs and Models) because if I selected one graph within Graphs and then, I switch to Models and I selected a model there, I get the comparison button. I think the rule should be that every time you switch views, you clean that up.

Yes! That's exactly what I am working on right now while debugging, I was fighting with Vue.js about it, but I like your idea of splitting the store as well. That will simplify my life.

YohannParis commented 3 years ago

@RosaRomeroGomez all your comments have been taken care of, finally! I tried to monkey break it, but it works as expected. This has become a big PR...

mj3cheun commented 3 years ago
Screen Shot 2021-05-27 at 11 23 52 AM

Up to you if you want to address this now or later, but the comparison page headers seem to be a bit off

YohannParis commented 3 years ago

Up to you if you want to address this now or later, but the comparison page headers seem to be a bit off

I think this PR is too big already, this will be best addressed as a new issue.