Closed YohannParis closed 3 years ago
It seems we should clean up the selectedModel store variable between views (Graphs and Models) because if I selected one graph within Graphs and then, I switch to Models and I selected a model there, I get the comparison button. I think the rule should be that every time you switch views, you clean that up.
Yes! That's exactly what I am working on right now while debugging, I was fighting with Vue.js about it, but I like your idea of splitting the store as well. That will simplify my life.
@RosaRomeroGomez all your comments have been taken care of, finally! I tried to monkey break it, but it works as expected. This has become a big PR...
Up to you if you want to address this now or later, but the comparison page headers seem to be a bit off
Up to you if you want to address this now or later, but the comparison page headers seem to be a bit off
I think this PR is too big already, this will be best addressed as a new issue.
Why
How
views/Models
folder into three different folders:view/Models
which includes computational modelsview/Graphs
which includes knowledge graphsview/Comparison
for comparison between computational models and knowledge graphs.view/Home
intoview/Models/ModelsList
andview/Graphs/GraphsList
filtered based on the folder.view/Home
to display three links toKnowledge
,Models
, andGraphs
.Screenshot and Video
https://user-images.githubusercontent.com/636801/119735542-7d102700-be4a-11eb-8c8d-ba027b65020a.mov
Testing