search

uncharted-aske / HMI

Apache License 2.0
1 stars 0 forks source link

Add neighbors to node panel of bio subgraph #260

Closed mj3cheun closed 3 years ago

mj3cheun commented 3 years ago

Add in and out neighbour lists to the bio subgraph populated using bgraph for the currently selected node. Test by selecting different nodes in the bio subgraph.

Fixes #251

https://user-images.githubusercontent.com/14062458/125315658-55dfbd00-e305-11eb-8b17-b1e1bb00c8bb.mov

Notes: This PR changes how collapsible container and collapsible item works, by changing the CSS that fits these two components to the parent container. It is likely that this change will break existing components that use these two components. From a quick search, that appears to be only the edge panel which is currently disabled. I think we should just keep this in mind, keep an eye on it, and fix any potential problems when they appear. It will be good to double check that there are no other actively used components incorporating collapsible components though.

YohannParis commented 3 years ago

I did a big chunk of work on the drilldown panel that was merged into main. It will be easier to resolve those conflict before reviewing. Sorry, I wasn't aware you were working on the same component as I was.

RosaRomeroGomez commented 3 years ago

I'm getting an error when I select a node: image Additionally, I see that there are many duplicates here. Not sure if this comes from bgraph or from the actual dataset. Don't worry too much about this. We can fix it in a subsequent PR. image

RosaRomeroGomez commented 3 years ago

One last comment is about displaying relationships that are already in the subgraph. I think we should remove those as well.