uncharted-aske / HMI

Apache License 2.0
1 stars 0 forks source link

Add static doc cluster render #272

Closed adamocarolli closed 3 years ago

adamocarolli commented 3 years ago

Description

Add document cluster renderer.

Changes

Considerations

Testing

Artifacts

Screen Shot 2021-07-19 at 2 50 54 PM

Contributors:

RosaRomeroGomez commented 3 years ago

I also noticed that the Show more link in the Drilldown panel doesn't work when you click on it.

Anyways, we can move all these points to a ticket and start addressing them when possible.

adamocarolli commented 3 years ago

It works well and looks good!

Here are some minor issues that are out of the scope of this PR, but to keep a record:

  • BGraph and Grafer are not typed.
  • Scrolling up and down on Chrome slides the whole page.
  • Opening/closing the left panel makes grafer stutter.
  • Because of the considerable work done in the browser instead of a server (as Adamo mentioned), the app is completely frozen, even the loading component.
  • The closing button on the left panel is hidden by its title.
  • the search bar does not work.
  • The document counter under the search bar is hardcoded (176K.)
  • Zooming in and out inside the cluster makes some clusters name appears with a nice animation. But this animation is tied to the scroll position and can be left in an in-between state, which makes them unreadable. (This is probably best left to Dario but if I have time I should get to know Grafer more)

All very good points! I've bolded the ones that I'll be working on/have been working on.