Display the search bar on the model like on the simulation view.

uncharted-aske / HMI

Apache License 2.0

1 stars 0 forks source link

Display the search bar on the model like on the simulation view. #275

Closed YohannParis closed 3 years ago

YohannParis commented 3 years ago

What

After changing the search bar on the simulation view, the model view was not on par.

How

Clean up the Model view code and implemented the same ideas.
Random cleanup around.

Testing

The search bar is now hidden behind a toggle button, and the open simulation button match the close button on the simulation view.

mj3cheun commented 3 years ago

I pushed a hacky fix for the searchbar which originally didnt really work (the searchbar wouldnt slide out). need more investigation to come up with an elegant fix.

YohannParis commented 3 years ago

I pushed a hacky fix for the searchbar which originally didnt really work (the searchbar wouldnt slide out). need more investigation to come up with an elegant fix.

Could you tell me which browser you are using. I had no issue on Firefox and Safari. I'll look into it tomorrow.

mj3cheun commented 3 years ago

Using chrome 91

YohannParis commented 3 years ago

Please do not delete this branch. I would like to test and make sure why this hack was necessary.

YohannParis commented 3 years ago

I'm submiting the fix for the hack on another PR