Display other types of GroMEt metadata types

uncharted-aske / HMI

Apache License 2.0

1 stars 0 forks source link

Display other types of GroMEt metadata types #315

Closed YohannParis closed 3 years ago

YohannParis commented 3 years ago

What

fix #306
This is mostly for Functional Network GroMEts

How

Add other GroMEt MetadataType EquationDefinition, TextDefinition, and TextParameter.
If there is no metada, the drilldown does not open on the metadata tab.
Display those new types in the metadata drilldown.
The Metadata are displayed in the followind order based on availability: TextDefinition > TextParameter > EquationDefinition > CodeSpanReference

Screenshot

A box on the SIR model
The variable Beta

RosaRomeroGomez commented 3 years ago

I've noticed two things and one of them might be just my fault?

For the SIR model in PNC format, since we don't have metadata, when I click on the SIR box, I get the following error. We probably want to handle empty metadata.

Double clicking on the box doesn't collapse it or expand it. Is that happening to you too?

YohannParis commented 3 years ago

* Double clicking on the box doesn't collapse it or expand it. Is that happening to you too?

Indeed, this looks fishy it was merge conflict that was not done properly. It has been fixed.

YohannParis commented 3 years ago

* For the SIR model in PNC format, since we don't have metadata, when I click on the SIR box, I get the following error. We probably want to handle empty metadata.

Thank you, this was fixed.