uncharted-aske / HMI

Apache License 2.0
1 stars 0 forks source link

Consolidated fixes 1 #320

Closed mj3cheun closed 3 years ago

mj3cheun commented 3 years ago

Solves the following issues:

RosaRomeroGomez commented 3 years ago

Some comments:

YohannParis commented 3 years ago
* I think the goal for the save button was to make it look pressed or in other words, I think this button should actually act as a checkbox or toggle. So if it is checked (and it looks pressed), your runs are saved and displayed but if it is not, they are not saved and displayed. Let me know if this makes sense.

This is a completely new behaviour. I don't think it will mix well with the Auto-run option, suddenly at every change of a parameters we save an extra run? This can create dozens of runs really fast.

mj3cheun commented 3 years ago

Let me know which save button behaviour you would prefer, I think either could work, although for the toggle behaviour I would be tempted to incorporate an actual checkbox into the button.

As for displaying fewer labels, I think that could be done in a separate PR as part of a larger task to make the line charts truly responsive.