Remove hidden property - Githubissues

uncharted-aske / HMI

Apache License 2.0

1 stars 0 forks source link

Remove hidden property #333

Closed emilykuang closed 3 years ago

emilykuang commented 3 years ago

What

fix #281 by removing the hidden property of parameters and variables and renaming edited property to displayed
displayed makes more sense than hidden since it was the opposite meaning

Testing

Select a model and open the simulation view
Add parameters using the plus sign and make sure the yellow dots appear in the Model Panel
Remove parameters using the no icon and make sure the yellow dots disappear

Screenshot:

Updated screenshot with highlight box:

RosaRomeroGomez commented 3 years ago

The yellow dots are not disappearing for me when I unselect one of the parameters or variables from the Model panel. I suspect it is related to the bug you logged here: https://github.com/uncharted-aske/HMI/issues/328 Are you guys experiencing the same issue? @YohannParis @mj3cheun ?

emilykuang commented 3 years ago

The yellow dots are not disappearing for me when I unselect one of the parameters or variables from the Model panel. I suspect it is related to the bug you logged here: #328 Are you guys experiencing the same issue? @YohannParis @mj3cheun ?

Yes, I noticed this issue too before I started refactoring. The dots appear and disappear as expected when you only use the buttons at the top or only by double-clicking on the nodes. However, if you try to add all dots using the + button, then try to remove one by double-clicking, the dot doesn't disappear.

RosaRomeroGomez commented 3 years ago

The yellow dots are not disappearing for me when I unselect one of the parameters or variables from the Model panel. I suspect it is related to the bug you logged here: #328 Are you guys experiencing the same issue? @YohannParis @mj3cheun ?

Yes, I noticed this issue too before I started refactoring. The dots appear and disappear as expected when you only use the buttons at the top or only by double-clicking on the nodes. However, if you try to add all dots using the + button, then try to remove one by double-clicking, the dot doesn't disappear.

Thanks @emilykuang for the clarifications. I think this PR seems fine. Maybe you can assign yourself that bug and see if you can find the issue?