uncharted-aske / HMI

Apache License 2.0
1 stars 0 forks source link

Change from dropdown to modal box #334

Closed YohannParis closed 3 years ago

YohannParis commented 3 years ago

What

How

Video

https://user-images.githubusercontent.com/636801/128081253-9ac729e6-f31f-42f2-9296-f3162fba8a57.mov

RosaRomeroGomez commented 3 years ago

A couple of comments/suggestions:

YohannParis commented 3 years ago

Maybe we can add alt text or tooltip for the Run and Configuration buttons since we don't have labels there and that will be helpful for the user (we already have them for the save and reset buttons).

I added a tooltip css feature to display tooltip that are not the title attribute.

https://user-images.githubusercontent.com/636801/128211633-5e90efac-e281-4cc3-a9b3-c21464e93f26.mov

YohannParis commented 3 years ago

I was thinking that the modal is quite small. Maybe we can put everything on the same row or have two columns, one for the auto-run checkbox and one for the rest. I was doing some testing in terms of width (don't pay attention to the layout) and I think this might be better. I'm using width: 40vw.

I updated the modal to be wider, to be around 40vw.

Screen Shot 2021-08-04 at 12 55 53