search

uncharted-distil / distil

An analytic workbench for user-guided development of model pipelines
Apache License 2.0
13 stars 3 forks source link

Result summaries should filter table data #121

Closed cdbethune closed 7 years ago

cdbethune commented 7 years ago

Selecting categories / setting ranges on the active result summary should cause the data displayed in the tables to update accordingly.

cdbethune commented 7 years ago

This is has revealed a more fundamental issue - we currently create the results table client side by fetching the filtered data, fetch the results, and then appending the results onto the filtered data table. The problem with this approach is results are returned from the server unfiltered, so they don't properly line up with filtered data if rows are removed. At minimum, we need to send the d3m index down to client for both the filtered data and results to ensure that the results and data are joined properly. Ideally, we move the data/result join to the server and allowing for filters to be applied in the same way they are for filtered data.

Aside from that, the filters currently don't apply because they use the result set name (example o_196-class-0effae) as the filter key, which doesn't exist, when they should be using the name of the target variable. This is a relatively simple fix, but would still suffer from the issue listed above.