Closed alcwhite closed 2 years ago
@alcwhite yes, I can do a pr with some design tweeks after this is merged. I do think we'll want the ability to have a stacked bar chart as well. Is this a brand new type of chart or an adjustment to the column chart type?
@rheubach It's kind of a combination of the bar chart and the stacked column chart, so that'll probably be a separate chart type. I did the stacked column chart as a separate chart type from the regular column chart, but it might make sense to rework it as an alteration of the existing column instead of an entirely separate chart type. Any thoughts, @tmecklem ?
I switched to making stacked charts alterations to our current column/bar charts. I added stacking to the bar chart as well. It has the same design issues as the column chart.
@alcwhite I am good with either way. There's still a lot to learn about the charts and what makes them similar enough to be combined or different enough to be separate. Within reason, this leads me to be okay with more duplication in general. I appreciate the thought you're putting into this and your contributions!
This looks great!
Can it be configured so that the corners are less round, or even square? In some cases it can be more readable, specially for small bars like the last one in the example.
@jaimeiniesta We'll be updating the design of the bars once this is merged in to make them more readable--specifically so that individual sections don't have rounded corners within each column.
@alcwhite Are you comfortable with me merging this in and beginning to adjust the design?
@rheubach Unless @tmecklem has any objections, I'm fine with it.
@tmecklem objections?
Closes #50
This still needs some design work--all the sections individually have rounded corners, which looks a little weird. Unclear also if we want to do stacked bar charts in addition to stacked column charts. I went with the column chart since that's what the requester's example was.