unchartedelixir / uncharted

33 stars 8 forks source link

Configure Fill-Opacity on Scatter Plot #58

Open rheubach opened 2 years ago

rheubach commented 2 years ago

It would be nice to allow graph creators the ability to adjust the Fill-opacity attribute on the circles placed on the scatter plot. You can find a set value for the attribute on the "scatter-dot" circle within the live_scatter.html file.

rheubach commented 2 years ago

@alcwhite would this be an easy configuration to add to the scatter plot?

alcwhite commented 2 years ago

@rheubach Yes. Would the same opacity apply to all circles, or should there be circle-specific configuration for this?

rheubach commented 2 years ago

@alcwhite I can't think of situations someone would want them to be different opacities, but I would like to side on the most configurable design. So, let's set it for each individual circle. Plus we can already set a different color for each circle, so it will be consistent with that.

markeasterling commented 2 years ago

@rheubach I'd like to try to do this. not sure how to assign myself

rheubach commented 2 years ago

@markeasterling got you covered! I also invited you to join the uncharted team so you can create PRs without having to fork the repo.

markeasterling commented 2 years ago

thanks Beau!

markeasterling commented 2 years ago

hey, @rheubach I see that 0.6 was hardcoded in for point's fill opacity. would you like that to be the default value if one isn't supplied?

rheubach commented 2 years ago

@markeasterling Yes, let's make 0.6 the default. Thanks!