Fixes #86 - Githubissues

unchase / Unchase.Odata.Connectedservice

:scroll: A Visual Studio extension for connecting to OData services with generating client-side C# proxy-classes

Apache License 2.0

44 stars 13 forks source link

Fixes #86 #87

Open dixonte opened 2 years ago

dixonte commented 2 years ago

I'm not 100% happy with this as I am sure I left a lot of stuff untouched that needed updating, but it works for my specific case.

Replaces spaces with underscores in member names in C#
Uses underscore instead of @ for reserved words in C#, so it can be used in private members
Adds 'Context' to list of reserved words, to prevent hiding necessary inherited member
Adds an option to write the Edmx as an embedded file instead of a string literal

dixonte commented 2 years ago

Undid the replacement of @ with underscore for conflicts with language keywords
Added a different check for conflicts with important inherited members, like Context. Underscore gets added to the end of these members

dazinator commented 1 year ago

Any news on when this might be merged?

dazinator commented 1 year ago

@dixonte I've been using your fork, also targeting Dynamics 365 FO, I have been seeing the following error, not sure if it is related to your changes or not, wondered if you had seen it? I ticked the option to generate client with property change tracking, and "async base"

Have created issue details here: https://github.com/unchase/Unchase.Odata.Connectedservice/issues/92