Extend the component API

unclecheese / react-selectable

A component for react that allows mouse selection of child items

MIT License

142 stars 72 forks source link

Extend the component API #51

Closed danilvalov closed 4 years ago

danilvalov commented 6 years ago

add the onBeginSelection prop;
add the onEndSelection prop;
add the selectingClassName prop;
update the onSelection callback logic (remove the selectOnMouseMove prop).

ssorallen commented 5 years ago

Can you remove the whitespace and editor changes? It's tough to accept a pull request on an open source project that adds new whitespace and editor preferences. It'd be easier to potentially merge without those changes.

danilvalov commented 4 years ago

@ssorallen Done

dreamofdark commented 4 years ago

@unclecheese Hello! What about merge this pull request?

unclecheese commented 4 years ago

Thanks, everyone! Will tag as 2.1.0.