search

unclecheese / silverstripe-display-logic

The Display Logic module allows you to add conditions for displaying or hiding certain form fields based on client-side behavior.
BSD 3-Clause "New" or "Revised" License
74 stars 71 forks source link

[CRINGE]: Replace master/slave references #148

Open unclecheese opened 1 year ago

unclecheese commented 1 year ago

Embarrassing and gross. Let's get this merged as soon as possible and set fire to all the previous commits. Thanks.

NightJar commented 1 year ago

Site won't load anymore, sorry PHP Parse error: syntax error, unexpected token "(" in unclecheese/display-logic/src/Criterion.php on line 86

chrispenny commented 1 year ago

I think this would be a breaking change (protected is technically part of the API). Thankfully I was already planning a new major for Silverstripe 5, so I'll pick this up again as part of https://github.com/unclecheese/silverstripe-display-logic/pull/152

GuySartorelli commented 1 year ago

Property names are part of the API as of PHP 8 as well, FYI. Another reason it should be done in a major.