search

unclecheese / silverstripe-display-logic

The Display Logic module allows you to add conditions for displaying or hiding certain form fields based on client-side behavior.
BSD 3-Clause "New" or "Revised" License
74 stars 71 forks source link

UploadField now requires a DisplayLogicWrapper? #35

Closed purplespider closed 9 years ago

purplespider commented 9 years ago

In 1.0.8 it used to be possible to use display conditions directly on an UploadField. However, this seemed to break completely in 1.1.0, and in the latest master only seems possible when using a DisplayLogicWrapper around the UploadField.

Just wanted to check if this was the desired behaviour? As took me a while to work out why it has stopped working, and would be good to have an UploadField example in the docs. :)

purplespider commented 9 years ago

Doh! You do have an UploadField example in the docs!

unclecheese commented 9 years ago

It is the desired behaviour. All non-standard form fields will now need wrappers. The only realistic alternative is to override the form field holders, and in finding that just creates way too many conflicts and unexpected outcomes.

This will all be documented once dev-mater gets tagged to 1.2.

On 24/01/2015, at 09:10, James Cocker notifications@github.com wrote:

In 1.0.8 it used to be possible to use display conditions directly on an UploadField. However, this seemed to break completely in 1.1.0, and in the latest master only seems possible when using a DisplayLogicWrapper around the UploadField.

Just wanted to check if this was the desired behaviour? As took me a while to work out why it has stopped working, and would be good to have an UploadField example in the docs. :)

— Reply to this email directly or view it on GitHub.

purplespider commented 9 years ago

Thanks for confirming, and thanks for your latest add-ons. Permamail and Dropzone will come in extremely useful! :)

unclecheese commented 9 years ago

Hey, man. That’s awesome to hear. Hit me up in IRC or email me at unclecheese at leftandmain dotcom if you ever have any further feedback.. always keen to hear. I’m really excited about these two.

aaron_carlino: { web_developer: “leftandmain.com" }

On Saturday, 24 January 2015 at 12:16 pm, James Cocker wrote:

Thanks for confirming, and thanks for your latest add-ons. Permamail and Dropzone will come in extremely useful! :)

— Reply to this email directly or view it on GitHub (https://github.com/unclecheese/silverstripe-display-logic/issues/35#issuecomment-71283236).