search

unclecheese / silverstripe-display-logic

The Display Logic module allows you to add conditions for displaying or hiding certain form fields based on client-side behavior.
BSD 3-Clause "New" or "Revised" License
74 stars 71 forks source link

Silverstripe 4 support #81

Closed adrexia closed 1 year ago

adrexia commented 7 years ago

Some work has been done in this pull request + thread to update to Silverstripe 4, but there were still some issues to resolve and the pull request was eventually closed.

https://github.com/unclecheese/silverstripe-display-logic/pull/78

jjjjjjjjjjjjjjjjjjjj commented 6 years ago

There are now two pull requests for SS4 support.

Perhaps we can discuss here regarding how to move forward.

Both come with SS4 compatibility updates, and some code formatting (PSR-2).

Other PR specific changes:

82 Breaks out (Extensi|Injecta|Configura)ble to DisplayLogicMain which is extended by DisplayLogicCriteri(a|on)

83 Adds yarn, adds webpack, adds unit tests, adds onkeyup JS listener.

fonsekaean commented 6 years ago

Added two of the main items from the PR #83 on this comment https://github.com/unclecheese/silverstripe-display-logic/pull/82#issuecomment-347736625

gorriecoe commented 6 years ago

Is anything happening with these PR's? #83 seems to work the best and would like to see merged in to master. I found that #82 intermittently stopped working.

muskie9 commented 6 years ago

I think a merge to get this 4 compatible would allow easier fixing. Currently it's causing some pain when requiring other modules that are 4 compatible and reference this module as a requirement.

christopherdarling commented 2 years ago

Issue could be closed v2 is SS4 compatible - https://github.com/unclecheese/silverstripe-display-logic/pull/82