search

unclecheese / silverstripe-event-calendar

The Event Calendar module for SilverStripe
GNU General Public License v2.0
31 stars 78 forks source link

SS4 upgrade #152

Closed gheggie closed 4 years ago

gheggie commented 4 years ago

Initial take for an SS4 version. Notable things:

  1. I've tested this with a fresh 4.4.3 version of Silverstripe CMS
  2. The Carbon PHP date/time API extension (https://carbon.nesbot.com/) replaces the sfDateTime stuff. It's added as a dependency via composer, but is the 1.x version; there was a conflict issue with Carbon 2.x and a symfony/translation dependency (from silverstripe/framework) that I wasn't sure how to resolve.
  3. The client/ dir has a package.json file that I'd started on, with the idea of re-writing the calendar widget js code, but it hasn't really progressed beyond that
  4. Still no unit/functional tests as you can see (and I probably wont write any)
sheadawson commented 4 years ago

Awesome work Grant. @unclecheese are we able to get this merged? I will need this for an upcoming project.

unclecheese commented 4 years ago

Wow. Can't believe this thing lived to see SS4. Nice job.

unclecheese commented 4 years ago

Tagged as 2.0.0.