search

unclecheese / silverstripe-gridfield-betterbuttons

Adds new form actions and buttons to the GridField detail form
GNU General Public License v2.0
80 stars 88 forks source link

DataModel removed in ss4-beta4 #167

Open jackoconnor21 opened 6 years ago

jackoconnor21 commented 6 years ago

DataModel has been removed in ss4-beta4 and so is causing breaks in GridFieldBetterButonsItemRequest.php on lines 75 & 89.

tim-lar commented 6 years ago

also, the class SilverStripe\ORM\Versioning\Versioned has moved to SilverStripe\Versioned\Versioned

mr-macedawg commented 6 years ago

170

Hopefully @unclecheese approves this. I have manually made these changes on my site to confirm it works.

Martimiz commented 6 years ago

Hi uncle, all

Namespace also needs fixing in BetterButtonDataObject, just noticed...

Has anyone got this working for versioned dataobjects yet? Even with these fixes, for me the cms (4 stable) just hangs on loading (page reload)...

silverstripe-elliot commented 6 years ago

I have raised a PR for this here: https://github.com/unclecheese/silverstripe-gridfield-betterbuttons/pull/172

I have closed my PR, somebody else has raised one here: https://github.com/unclecheese/silverstripe-gridfield-betterbuttons/pull/170