search

unclecheese / silverstripe-gridfield-betterbuttons

Adds new form actions and buttons to the GridField detail form
GNU General Public License v2.0
80 stars 88 forks source link

Incorrect redirection when a Versioned DataObject is published #174

Open shaunjc opened 6 years ago

shaunjc commented 6 years ago

https://github.com/unclecheese/silverstripe-gridfield-betterbuttons/blob/eeeb5b4700d565b32a43fb41a7df9a8333263a59/src/Extensions/GridFieldBetterButtonsItemRequest.php#L351-L353

$redirectURL is actually a \SilverStripe\Forms\FormRequestHandler instance, so users are always forced to incorrectly redirect to /SilverStripe/Forms/FormRequestHandler whenever a Versioned DataObject is published. Additional checks to ensure $redirectURL is a string should be added, or these lines should be removed.

andreaslindahl commented 6 years ago

Any news on this? Will it be fixed?

unclecheese commented 6 years ago

The SS4 upgrade is very much in flux, and I'm looking to wrap it up this week. See the feature/ss4-upgrade branch.