unclecheese / silverstripe-gridfield-betterbuttons

Adds new form actions and buttons to the GridField detail form
GNU General Public License v2.0
80 stars 88 forks source link

FIX (1.3): Better maintenance of state for the save draft + publish buttons #183

Open patricknelson opened 5 years ago

patricknelson commented 5 years ago

Addresses to important issues I've identified:

  1. Going in to edit a record will not reflect if it has a publishable version or not (33a6fcc)
  2. Changing a record doesn't dynamically update the two submit buttons at the bottom like it should (8d4991a)

Granted #​2 is just a revert of another commit (245caaf), however, this functionality is entirely consistent with other Version'ed objects, i.e. SiteTree. I acknowledge that maintaining this functionality (i.e. button state updating if the form is modified in any way), however I believe that should be classified as a separate bug that should instead be addressed in silverstripe-cms, given it is more broad and consistency and, more importantly, visual feedback on current state is more valuable (in my subjective opinion).

patricknelson commented 5 years ago

Bump!