unclecheese / silverstripe-gridfield-betterbuttons

Adds new form actions and buttons to the GridField detail form
GNU General Public License v2.0
80 stars 88 forks source link

Silverstripe 4 branch assumes Versioned #187

Open robingram opened 5 years ago

robingram commented 5 years ago

When trying to upgrade an existing site to SS4 using the recommended branch I'm getting errors when trying to edit a data object that isn't versioned.

This is because the Delete button calls $record->isPublished(). This is a change to the SS3 implementation which called a method in the GridFieldBetterButtonsItemRequest class that checked for the existence of the Versioned extension on the data object first.

jinjie commented 5 years ago

Assume $record is "published" if it is not versioned.