search

unclechu / node-deep-extend

Recursive extend module
MIT License
202 stars 53 forks source link

Async #16

Closed unclechu closed 8 years ago

tsturzl commented 9 years ago

What does this mean? Just having a callback? It doesn't really make any sense, because either way this will block being that its a logical task not something thats being waited on like IO. Having a callback would just make it messier to use and increase the amount of used stack space by creating an unnessesary function.

kevin-smets commented 8 years ago

If people really want this, they could always use bluebird and promisify the extend. Not that I really see the benefit in making this operation async. Can it become real slow for heavy objects or something?

unclechu commented 8 years ago

Decided not to do it.