search

unclechu / node-deep-extend

Recursive extend module
MIT License
202 stars 53 forks source link

react-native Buffer is not defined #42

Open tjbenton opened 6 years ago

tjbenton commented 6 years ago

When trying to use this library with react-native it throws the following error saying Buffer is not defined.

screen shot 2018-06-20 at 9 49 45 am

I know I can install buffer as a dependency but I would like to avoid adding another dependency to my project when we aren't using Buffer at all.

I resolved the error by adding the following to my code before I used deepExtend.

global.Buffer = global.Buffer || class Buffer {}

if you actually need the functionality for another library, install buffer as a dependency 

global.Buffer = global.Buffer || require('buffer').Buffer
vicapow commented 5 years ago

this also affects client side code that doesn't have the Buffer polyfill. this recently caused issues in https://github.com/uber/streetscape.gl/pull/167

the fix should just be to check for buffer existing using typeof Buffer !== 'undefined' before using Buffer

vicapow commented 5 years ago

looks liked, based on https://github.com/unclechu/node-deep-extend/pull/27 This module is not actively maintained

ardok commented 5 years ago

Was wondering about this. Will switch to lodash.merge instead